Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected wording in the script Update remove-ignored-artifacts.js #5355

Closed
wants to merge 1 commit into from

Conversation

mdqst
Copy link
Contributor

@mdqst mdqst commented Dec 10, 2024

A minor but important typo in the script that removes build artifacts for ignored contracts.

The message currently reads:

console.error(`Removed ${n} mock artifacts`);

While the term "mock" is commonly used for test data, it is not the most accurate term in this case. The script is removing artifacts related to ignored contracts, so the word "ignored" better represents the action being performed.

The corrected line now reads:

console.error(`Removed ${n} ignored artifacts`);

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Copy link

changeset-bot bot commented Dec 10, 2024

⚠️ No Changeset found

Latest commit: 92119b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx
Copy link
Collaborator

Amxx commented Dec 16, 2024

contracts/package.json (that is used for releasing) contains

[
  "**/*.sol",
  "/build/contracts/*.json",
  "!/mocks/**/*"
]

similarly package.json contains

[
  "/contracts/**/*.sol",
  "!/contracts/mocks/**/*"
]

In practice, the contracts that are ignored are all mocks. In the futur, I believe this feature will only ever be used for testing related contracts. So the wording is accurate in our case.

@Amxx Amxx closed this Dec 16, 2024
@Amxx Amxx added automation Tests and coverage running. Docsite publishing. ignore-changeset labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Tests and coverage running. Docsite publishing. ignore-changeset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants