-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize Math operations using branchless bool to uint translation. #4878
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7f5b1b3
Make Math.log2 branchless
CodeSandwich 7523995
add Math.boolToUint
Amxx 45bbe87
branchless rounding
Amxx c8e9e3c
Make boolToUint clean the upper bits
CodeSandwich 32b3d97
Make log2 more readable
CodeSandwich 8417107
Update .changeset/nervous-pans-grow.md
Amxx 3ae1b4a
Move `boolToUint` to `SafeCast`
ernestognw f8cb792
Update .changeset/nervous-pans-grow.md
ernestognw a371515
fix generation
Amxx b0ad358
Merge branch 'master' into optimize_log2
Amxx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks to me more of a fit into the
SafeCast
library with thefunction toUint(bool b)
signature as it already requires a boolean as an argument.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm totally fine with this, but does it fit the other functions from
SafeCast
? IIUC the main goal of this library is to make dangerous operations and throw in case of an overflow. IntoUint256(bool)
there's no overflow possible, there's nothing "safe" about thisSafeCast
function.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's right, I don't have the last word but I feel confident that
SafeCast
is a better fit thanMath
.We might consider having these unconventional casts in a different library but that's a broader discussion.