Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize nested mapping access in ERC721Enumerable #4545

Conversation

0xVolosnikov
Copy link
Contributor

Optimized access to nested mapping: avoiding the need to calculate the index of a slot in the storage several times.

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2023

⚠️ No Changeset found

Latest commit: 0edf4db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@Amxx Amxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a big fan of this syntax, which I find less readable ... but it saves 76gas on some run.

@ernestognw WDYT?

@ernestognw
Copy link
Member

I'm not a big fan of this syntax, which I find less readable ... but it saves 76gas on some run.

@ernestognw WDYT?

Also not a fan of the syntax, but I think it's pretty much what we intended here and I'd rather keep the gas savings since I don't see how this might be dangerous or something.

@ernestognw ernestognw merged commit ad27fb6 into OpenZeppelin:master Mar 25, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants