Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve customError testing #4376

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Jun 20, 2023

Currently, if the promise does not fail, expect.fail("Expected promise to throw but it didn't"); is triggered but instantly catched. Since this message doesn't follow the expected format:

VM Exception while processing transaction: reverted with custom error 'ErrorName(params)'

the following line fails

const [, error] = revert.message.match(/'(.*)'/);

with

TypeError: object null is not iterable (cannot read property Symbol(Symbol.iterator))

@Amxx Amxx added tests Test suite and helpers. ignore-changeset labels Jun 20, 2023
@Amxx Amxx requested a review from ernestognw June 20, 2023 09:02
@changeset-bot
Copy link

changeset-bot bot commented Jun 20, 2023

⚠️ No Changeset found

Latest commit: 962134c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx Amxx force-pushed the testing/helpers/customError branch from 474ed04 to 3eaafcc Compare June 20, 2023 13:04
@Amxx Amxx requested a review from frangio June 20, 2023 16:13
@Amxx Amxx merged commit dac2457 into OpenZeppelin:master Jun 20, 2023
@Amxx Amxx deleted the testing/helpers/customError branch June 20, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-changeset tests Test suite and helpers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants