Fix attempt to delete nonexistent npm tag #4374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ernestognw
approved these changes
Jun 20, 2023
Amxx
approved these changes
Jun 20, 2023
frangio
added a commit
that referenced
this pull request
Jul 28, 2023
(cherry picked from commit 9fa550c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release workflows for 4.9.1 and 4.9.2 failed because there's an attempt to delete the
nexttag, which is not present when we're releasing a patch. This PR will first check if the next tag exists, but also if it should be deleted. If we havenext: 5.0.0-rc.0and we publishlatest: 4.9.4we don't want to delete thenexttag in that case.