Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename toString to toStringSigned #4330

Merged
merged 10 commits into from
Jun 19, 2023
Merged

Rename toString to toStringSigned #4330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
76f5701
feat: adds toStringSigned & its tests
balajipachai Jun 9, 2023
27c7c25
fix: removes StringsMock & updates tests
balajipachai Jun 10, 2023
fa07c12
Merge branch 'master' into string-tostring-compile-with-integer-literal
balajipachai Jun 10, 2023
2d9a47f
fix: implements the reviewed changes
balajipachai Jun 15, 2023
016925f
Merge branch 'master' into string-tostring-compile-with-integer-literal
balajipachai Jun 15, 2023
c6240a6
Update contracts/utils/Strings.sol
balajipachai Jun 16, 2023
38aa0de
Update test/utils/Strings.test.js
balajipachai Jun 16, 2023
b574b0a
Update test/utils/Strings.test.js
balajipachai Jun 16, 2023
6814161
feat: adds changeset
balajipachai Jun 16, 2023
2a39ea1
Update .changeset/tasty-tomatoes-turn.md
balajipachai Jun 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tasty-tomatoes-turn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'openzeppelin-solidity': major
---

`Strings`: Rename `toString(int256)` to `toStringSigned(int256)`.
2 changes: 1 addition & 1 deletion contracts/utils/Strings.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ library Strings {
/**
* @dev Converts a `int256` to its ASCII `string` decimal representation.
*/
function toString(int256 value) internal pure returns (string memory) {
function toStringSigned(int256 value) internal pure returns (string memory) {
return string.concat(value < 0 ? "-" : "", toString(SignedMath.abs(value)));
}

Expand Down
8 changes: 4 additions & 4 deletions test/utils/Strings.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,22 +48,22 @@ contract('Strings', function () {
describe('int256', function () {
it('converts MAX_INT256', async function () {
const value = constants.MAX_INT256;
expect(await this.strings.methods['$toString(int256)'](value)).to.equal(value.toString(10));
expect(await this.strings.methods['$toStringSigned(int256)'](value)).to.equal(value.toString(10));
});

it('converts MIN_INT256', async function () {
const value = constants.MIN_INT256;
expect(await this.strings.methods['$toString(int256)'](value)).to.equal(value.toString(10));
expect(await this.strings.methods['$toStringSigned(int256)'](value)).to.equal(value.toString(10));
});

for (const value of values) {
it(`convert ${value}`, async function () {
expect(await this.strings.methods['$toString(int256)'](value)).to.equal(value);
expect(await this.strings.methods['$toStringSigned(int256)'](value)).to.equal(value);
});

it(`convert negative ${value}`, async function () {
const negated = new BN(value).neg();
expect(await this.strings.methods['$toString(int256)'](negated)).to.equal(negated.toString(10));
expect(await this.strings.methods['$toStringSigned(int256)'](negated)).to.equal(negated.toString(10));
});
}
});
Expand Down