Remove Counters library and its usage

[balajipachai]

Fixes #4233

• Deletes Counters.sol and its associated tests

• Counters.sol was imported in below contracts:

  contracts/governance/utils/Votes.sol

  contracts/mocks/proxy/UUPSUpgradeableMock.sol

  contracts/token/ERC20/extensions/ERC20Permit.sol

  contracts/token/ERC20/extensions/ERC20Snapshot.sol

  contracts/token/ERC721/presets/ERC721PresetMinterPauserAutoId.sol

removed usage of Counters in these contracts and updated the code accordingly.

PR Checklist

• [All are passing] Tests
• [None] Documentation
• [Added relevant changeset file] Changeset entry (run npx changeset add)

[changeset-bot]

🦋 Changeset detected

Latest commit: 6c1cc89

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
openzeppelin-solidity	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[frangio]

Sorry @balajipachai, just noticing we have a duplicate PR for this at #4289. 🙏

[balajipachai]

@frangio the PR #4289 was made after #4281, thus, it is hard for me to understand why 4281 was closed and not 4289?

[Amxx]

This PR is based on the master branch, while 4281 is based on, and targets next-v5.0, which is the branch we are actively working on. Given the differences between these branches, using this PR would result in many conflicts.

[balajipachai]

This PR is based on the master branch, while 4281 is based on, and targets next-v5.0, which is the branch we are actively working on. Given the differences between these branches, using this PR would result in many conflicts.

Does this mean all the issues cited in Milestone-5 should be targeted to next-v5.0 branch?
If I would have received a comment to make the PR targeting next-v5.0, I would have done that happily and solved most of the conflicts.

@frangio @Amxx

[Amxx]

Does this mean all the issues cited in Milestone-5 should be targeted to next-v5.0 branch?

Yes.

Considering we are currently working on a very tight schedule we are working on all the 5.0 issues internally.

[balajipachai]

Can you assign me some of those issues with a deadline? I will complete and resolve all the assigned issues well within the deadline 100%

[frangio]

@balajipachai Yeah sorry about the confusion. We just merged the next-v5.0 and master branches. master is now again the main branch to work on so we will avoid this issue going forward.

I mentioned you in #3693.