[next-v5.0] Refactor ERC721 _transfer function to support minting and burning #3636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frangio
reviewed
Aug 25, 2022
|
We should do the same with ERC20 and 1155. |
Amxx
force-pushed
the
refactor/erc721/mint-burn-transfer
branch
from
c3514e6 to
9bd2053
Compare
yes, but in other PRs :) |
frangio
reviewed
Sep 15, 2022
| address to, | ||
| uint256 tokenId | ||
| ) internal virtual override { | ||
| super._transfer(from, to, tokenId); | ||
|
|
||
| if (bytes(_tokenURIs[tokenId]).length != 0) { |
There was a problem hiding this comment.
This function should only do this if to is 0!
3 tasks
|
Superceded by #3893. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3535
Also remove before and after transfer hooks
Replace #3635
PR Checklist