Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC721 transfer should not emit Approval event #3483

Closed

Conversation

AnAllergyToAnalogy
Copy link
Contributor

As per the ERC721 standard, the Approval event should not be emitted on token transfer. It is implicit in the emitted Transfer event.

    /// @dev This emits when the approved address for an NFT is changed or
    ///  reaffirmed. The zero address indicates there is no approved address.
    ///  When a Transfer event emits, this also indicates that the approved
    ///  address for that NFT (if any) is reset to none.
    event Approval(address indexed _owner, address indexed _approved, uint256 indexed _tokenId);

@k06a
Copy link
Contributor

k06a commented Jun 16, 2022

I think this discussion could be also related to the topic: makerdao/dss#76 and #1955

@AnAllergyToAnalogy
Copy link
Contributor Author

Those discussions refer to ERC20, whereas this refers to ERC721. The ERC721 Standard is unambiguous about this, the Approval event shouldn't be emitting on a transfer.

@Amxx
Copy link
Collaborator

Amxx commented Jun 16, 2022

You opened this PR twice.

Please lets only keep one instance opened #3483

@Amxx Amxx closed this Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants