Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IncPriceCrowdsale consistently returns 0 outside of the crowdsale window. #1442

Merged
merged 1 commit into from
Oct 18, 2018
Merged

IncPriceCrowdsale consistently returns 0 outside of the crowdsale window. #1442

merged 1 commit into from
Oct 18, 2018

Conversation

nventuro
Copy link
Contributor

It used to revert when called before, and return the final rate when called after, this is more consistent (and hopefully clearer).

@nventuro nventuro added this to the v2.0 milestone Oct 18, 2018
@nventuro nventuro requested a review from come-maiz October 18, 2018 18:29
come-maiz
come-maiz approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@come-maiz come-maiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good. We should agree on rules of when to return 0 and when to revert, but consistency inside the same contract is a good step for sure.

@nventuro nventuro merged commit 9155bfe into OpenZeppelin:master Oct 18, 2018
@nventuro nventuro deleted the inc-price-crowdsale-rate branch October 18, 2018 19:36
come-maiz pushed a commit that referenced this pull request Oct 21, 2018
@nventuro @come-maiz
IncPriceCrowdsale consistently returns 0 outside of the crowdsale win…
2e848e1 
…dow. (#1442)

(cherry picked from commit 9155bfe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-maiz come-maiz come-maiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nventuro @come-maiz