-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update modifiers to call public view functions #1277
Update modifiers to call public view functions #1277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good. Have you looked at the other modifiers in the codebase?
@@ -19,7 +19,7 @@ contract TimedCrowdsale is Crowdsale { | |||
*/ | |||
modifier onlyWhileOpen { | |||
// solium-disable-next-line security/no-block-members |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this Solium annotation because we moved the expression to a function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
@frangio yes, I've checked them all.
I think I would like to remove of all the |
Is there an example of that pattern outside of roles? Those have been removed as part of @nventuro's work on roles. |
046521d
to
50627db
Compare
Rebased on master. |
Yup, from what I recall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks @ElOpio! |
Fixes #1179.
Requires #1268, #1269, #1270.
π Description
It should be possible to query the condition that modifiers require.
npm run lint:all:fix
).