Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the use of call() with selector only. #1033

Merged
merged 2 commits into from
Jun 30, 2018
Merged

Update the use of call() with selector only. #1033

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eee5976
Update the use of call() with selector only.
chriseth Jun 13, 2018
4e605ab
Merge branch 'master' into callAndHash
frangio Jun 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/mocks/ReentrancyAttack.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ contract ReentrancyAttack {

function callSender(bytes4 data) public {
// solium-disable-next-line security/no-low-level-calls
require(msg.sender.call(data));
require(msg.sender.call(abi.encodeWithSelector(data)));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

call will enforce a single bytes argument, this way it will still work properly.

}

}