Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test setup helper #1205

Closed
nventuro opened this issue Aug 13, 2018 · 0 comments
Closed

Test setup helper #1205

nventuro opened this issue Aug 13, 2018 · 0 comments
Labels
feature New contracts, functions, or helpers. good first issue Low hanging fruit for new contributors to get involved! tests Test suite and helpers.

Comments

@nventuro
Copy link
Contributor

The following lines are repeated in almost every single test file:

const BigNumber = web3.BigNumber;

require('chai')
  .use(require('chai-bignumber')(BigNumber))
  .should();

We should have a helper function that setups chai, probably exposing BigNumber along the way (which will also allow us to easily change that dependency in the future if we wish to). Some tests also need should, which should be exposed as well.

@nventuro nventuro added feature New contracts, functions, or helpers. tests Test suite and helpers. labels Aug 13, 2018
@nventuro nventuro added this to the v2.1 milestone Aug 13, 2018
@nventuro nventuro added the good first issue Low hanging fruit for new contributors to get involved! label Aug 13, 2018
Aniket-Engg added a commit to Aniket-Engg/zeppelin-solidity that referenced this issue Oct 25, 2018
nventuro added a commit to Aniket-Engg/zeppelin-solidity that referenced this issue Dec 7, 2018
nventuro pushed a commit that referenced this issue Dec 7, 2018
* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a688977.

* updates

* fixes #1404

* approve failing test

* suggested changes done

* ISafeERC20 removed

* conflict fixes

* fixes #1205

* minor change

* suggested changes

* reviewed changes

* final update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New contracts, functions, or helpers. good first issue Low hanging fruit for new contributors to get involved! tests Test suite and helpers.
Projects
None yet
Development

No branches or pull requests

1 participant