Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Proxies.md #388

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Update Proxies.md #388

merged 1 commit into from
Jul 11, 2022

Conversation

dancewithtruth
Copy link
Contributor

Edit Python initialization call doc to be the same func name / signature as the mock implementation contract example.

Edit Python initialization call to be the same func name / signature as the mock implementation contract example.
@martriay
Copy link
Contributor

martriay commented Jul 11, 2022

Thanks for doing this! 🎉

I know it's a small PR, but please follow our contributing guidelines even for small ones like this PR. For example, it's hard for us to organize our reviewing and releasing process without an associated issue, or maybe there's implementation details that need discussion (maybe not for this one), or someone else is already working on this, or the PR is simply not wanted for some reason.

For this PR it's ok, but please be mindful on next ones!

@martriay martriay merged commit d0223e5 into OpenZeppelin:main Jul 11, 2022
@dancewithtruth
Copy link
Contributor Author

Thanks for doing this! 🎉

I know it's a small PR, but please follow our contributing guidelines even for small ones like this PR. For example, it's hard for us to organize our reviewing and releasing process without an associated issue, or maybe there's implementation details that need discussion (maybe not for this one), or someone else is already working on this, or the PR is simply not wanted for some reason.

For this PR it's ok, but please be mindful on next ones!

Apologies, will do that next time. Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants