Simplify paths for fetching contract classes in tests #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martriay
approved these changes
Jul 12, 2022
tests/security/test_initializable.py
Outdated
|
|
||
| signer = MockSigner(12345678987654321) |
There was a problem hiding this comment.
Ah it's not!
| @@ -11,7 +11,7 @@ | |||
| async def reentrancy_mock(): | |||
| starknet = await Starknet.empty() | |||
| contract = await starknet.deploy( | |||
| "tests/mocks/reentrancy_mock.cairo", | |||
| contract_class=get_contract_class("reentrancy_mock"), | |||
There was a problem hiding this comment.
Without the contract_class kwarg, you mean?
| account_cls = get_contract_class('Account') | ||
| erc721_cls = get_contract_class('ERC721_Mintable_Burnable') | ||
| erc721_holder_cls = get_contract_class('ERC721_Holder') | ||
| unsupported_cls = get_contract_class('Initializable') |
Co-authored-by: Martín Triay <martriay@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to simplify getting contract classes in the test environment. Instead of passing the entire path as an argument to
get_contract_class, this PR proposes to pass just the contract name. For example:as opposed to:
In the event that multiple preset contracts share the same name,
get_contract_classincludes the optional paramis_path. The syntax looks like this:Resolves #379.