Skip to content
This repository was archived by the owner on Feb 11, 2024. It is now read-only.

Add SkillEntry.from_directory #81

Merged
merged 4 commits into from
Feb 17, 2022

Conversation

NeonDaniel
Copy link
Member

Add local parsing option with unit tests
Related bugfixes in SkillEntry to ensure property types

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #81 (c473eb3) into master (ba89385) will increase coverage by 3.77%.
The diff coverage is 82.95%.

❗ Current head c473eb3 differs from pull request most recent head 0b92521. Consider uploading reports for the commit 0b92521 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   56.38%   60.15%   +3.77%     
==========================================
  Files          33       34       +1     
  Lines        2680     2718      +38     
==========================================
+ Hits         1511     1635     +124     
+ Misses       1169     1083      -86     
Impacted Files Coverage Δ
ovos_skills_manager/local_skill/__init__.py 70.14% <70.14%> (ø)
ovos_skills_manager/appstores/local.py 65.51% <78.57%> (+37.31%) ⬆️
ovos_skills_manager/skill_entry.py 67.23% <83.33%> (+0.87%) ⬆️
ovos_skills_manager/github/api.py 42.47% <90.90%> (+10.48%) ⬆️
ovos_skills_manager/github/__init__.py 73.41% <100.00%> (+4.71%) ⬆️
ovos_skills_manager/github/raw.py 63.89% <100.00%> (+0.10%) ⬆️
ovos_skills_manager/github/utils.py 94.01% <100.00%> (ø)
ovos_skills_manager/requirements.py 30.43% <100.00%> (+7.24%) ⬆️
...os_skills_manager/appstores/mycroft_marketplace.py 56.89% <0.00%> (-3.45%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1410ef...0b92521. Read the comment docs.

@NeonDaniel NeonDaniel force-pushed the FEAT_SkillEntryFromDirectory branch from f7704ff to f3a49c5 Compare February 4, 2022 00:30
@NeonDaniel NeonDaniel requested a review from JarbasAl February 4, 2022 01:10
Copy link
Member

@JarbasAl JarbasAl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChanceNCounter any feedback?

@ChanceNCounter
Copy link
Contributor

@ChanceNCounter any feedback?

Not on a 35-file PR I can't personally test, nope.

@JarbasAl
Copy link
Member

JarbasAl commented Feb 4, 2022

you know the files are basically just test skills you can ignore right?

@NeonDaniel NeonDaniel force-pushed the FEAT_SkillEntryFromDirectory branch from c473eb3 to 0b92521 Compare February 17, 2022 22:14
@JarbasAl JarbasAl merged commit 6594141 into OpenVoiceOS:master Feb 17, 2022
@NeonDaniel NeonDaniel deleted the FEAT_SkillEntryFromDirectory branch February 17, 2022 23:02
@JarbasAl JarbasAl added the enhancement New feature or request label Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants