-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/log_level_cfg #252
fix/log_level_cfg #252
Conversation
react to changes in log level from mycroft.conf
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #252 +/- ##
==========================================
- Coverage 42.40% 42.34% -0.07%
==========================================
Files 31 31
Lines 3127 3148 +21
==========================================
+ Hits 1326 1333 +7
- Misses 1801 1815 +14 ☔ View full report in Codecov by Sentry. |
Can you add some trivial unit test coverage that config changes are reacted to? (i.e. no reload if non-log config changed vs log re-init upon relevant config change). This should also resolve the failing codecov test |
the file watcher is tested here https://github.com/OpenVoiceOS/ovos-utils/blob/dev/test/unittests/test_file_utils.py#L56 and the config watcher itself is used in other services (audio and listener) and tested here https://github.com/OpenVoiceOS/ovos-config/blob/dev/test/unittests/test_configuration.py#L182 |
while this does react to file changes properly etc, the change in log level does not actually take effect when calling |
react to changes in log level from mycroft.conf
closes OpenVoiceOS/ovos-config#125
to test change level between info and debug, and confirm in services that it is respected