Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mac support for ram cache #231

Merged
merged 1 commit into from
Mar 23, 2024
Merged

Conversation

mikejgray
Copy link
Contributor

@mikejgray mikejgray commented Mar 23, 2024

Currently, the behavior of the RAM temp cache is to check for a posix result from os.name. Mac OS is a posix-based OS but the library in use only supports Linux. So, this PR makes it so the tempfile is only created if the OS is detected as Linux.

Not a hard requirement for Mac support but it gets rid of an annoying traceback. :)

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.53%. Comparing base (e711cee) to head (32b4204).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #231      +/-   ##
==========================================
+ Coverage   42.45%   42.53%   +0.08%     
==========================================
  Files          31       31              
  Lines        3060     3061       +1     
==========================================
+ Hits         1299     1302       +3     
+ Misses       1761     1759       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl added the bug Something isn't working label Mar 23, 2024
@JarbasAl JarbasAl merged commit 04fc16c into OpenVoiceOS:dev Mar 23, 2024
9 checks passed
@mikejgray mikejgray deleted the FEAT_MacSupport branch March 24, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants