Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/ocp_utils #215

Merged
merged 1 commit into from
Jan 6, 2024
Merged

refactor/ocp_utils #215

merged 1 commit into from
Jan 6, 2024

Conversation

NeonJarbas
Copy link
Contributor

shared constants moved to the common module

these enums are used in several places andhaving them elsewhere introduces circular dependencies

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

Attention: 85 lines in your changes are missing coverage. Please review.

Comparison is base (e011854) 40.52% compared to head (f59303f) 39.30%.
Report is 2 commits behind head on dev.

❗ Current head f59303f differs from pull request most recent head 2de18a7. Consider uploading reports for the commit 2de18a7 to get more accurate results

Files Patch % Lines
ovos_utils/ocp.py 0.00% 84 Missing ⚠️
ovos_utils/version.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #215      +/-   ##
==========================================
- Coverage   40.52%   39.30%   -1.22%     
==========================================
  Files          30       31       +1     
  Lines        2717     2801      +84     
==========================================
  Hits         1101     1101              
- Misses       1616     1700      +84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shared constants moved to the common module

these enums are used in several places andhaving them elsewhere introduces circular dependencies
@JarbasAl JarbasAl marked this pull request as ready for review January 6, 2024 00:59
@JarbasAl JarbasAl merged commit 26dfca6 into OpenVoiceOS:dev Jan 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging refactor code improvements with no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants