Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error log for GUI resource resolution #198

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Conversation

NeonDaniel
Copy link
Member

Closes #194

@NeonDaniel NeonDaniel requested a review from a team October 25, 2023 01:20
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a8f8fdc) 29.77% compared to head (bbee06a) 30.24%.
Report is 5 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #198      +/-   ##
==========================================
+ Coverage   29.77%   30.24%   +0.47%     
==========================================
  Files          49       49              
  Lines        6566     6629      +63     
==========================================
+ Hits         1955     2005      +50     
- Misses       4611     4624      +13     
Files Coverage Δ
ovos_utils/gui.py 46.92% <100.00%> (ø)
ovos_utils/version.py 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit 12eb830 into dev Oct 25, 2023
10 checks passed
@JarbasAl JarbasAl deleted the LOG_UpdateGuiLogging branch October 25, 2023 01:31
@github-actions github-actions bot mentioned this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GUI] _pages2uri reports page not found when omitting extension
2 participants