Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate the sound utils module #190

Merged
merged 4 commits into from
Oct 25, 2023
Merged

deprecate the sound utils module #190

merged 4 commits into from
Oct 25, 2023

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Sep 5, 2023

replaces/includes #188

lbt and others added 3 commits September 6, 2023 00:11
@lbt @JarbasAl
make play_*_sound more DRY
94af814 
Signed-off-by: David Greaves <david@dgreaves.com>
@lbt @JarbasAl
sound.audio_play() now prefers using a mycroft.audio.queue message
0a508a6 
Signed-off-by: David Greaves <david@dgreaves.com>
@JarbasAl
deprecate/audio_utils
67ffc29
@JarbasAl JarbasAl added the refactor code improvements with no functional changes label Sep 5, 2023
@JarbasAl JarbasAl requested review from NeonDaniel and a team September 5, 2023 23:35
@JarbasAl JarbasAl mentioned this pull request Sep 5, 2023
Merged
@codecov
Copy link

codecov bot commented Sep 5, 2023 •
edited
Loading

Codecov Report

Patch coverage: 48.00% and project coverage change: +0.20% 🎉

Comparison is base (70f15ac) 29.60% compared to head (90071ac) 29.81%.
Report is 2 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #190      +/-   ##
==========================================
+ Coverage   29.60%   29.81%   +0.20%     
==========================================
  Files          49       49              
  Lines        6519     6510       -9     
==========================================
+ Hits         1930     1941      +11     
+ Misses       4589     4569      -20
Files Changed Coverage Δ
ovos_utils/version.py 0.00% <0.00%> (ø)
ovos_utils/sound/__init__.py 67.10% <50.00%> (+10.58%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl mentioned this pull request Oct 18, 2023
Closed
@JarbasAl JarbasAl merged commit 16267b9 into dev Oct 25, 2023
10 checks passed
@JarbasAl JarbasAl deleted the deprecate/audio_utils branch October 25, 2023 01:11
@github-actions github-actions bot mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeonDaniel NeonDaniel NeonDaniel approved these changes

Assignees

@ChanceNCounter ChanceNCounter

@NeonDaniel NeonDaniel

Labels
refactor code improvements with no functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JarbasAl @NeonDaniel @ChanceNCounter @lbt