Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove _HACK #184

Merged
merged 1 commit into from
Aug 17, 2023
Merged

remove _HACK #184

merged 1 commit into from
Aug 17, 2023

Conversation

JarbasAl
Copy link
Member

fix #183 , move the HACK to dinkum directly instead for now

fix #183 , move the HACK to dinkum directly instead for now
@JarbasAl JarbasAl added the bug Something isn't working label Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #184 (946d6af) into dev (e233aa7) will decrease coverage by 0.12%.
Report is 2 commits behind head on dev.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev     #184      +/-   ##
==========================================
- Coverage   28.54%   28.43%   -0.12%     
==========================================
  Files          49       49              
  Lines        6501     6491      -10     
==========================================
- Hits         1856     1846      -10     
  Misses       4645     4645              
Files Changed Coverage Δ
ovos_utils/file_utils.py 56.08% <ø> (-2.21%) ⬇️
ovos_utils/version.py 0.00% <0.00%> (ø)

@JarbasAl JarbasAl merged commit 22bf10c into dev Aug 17, 2023
9 of 10 checks passed
@JarbasAl JarbasAl deleted the rmHACK branch August 17, 2023 15:31
@github-actions github-actions bot mentioned this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

__HACK_preload in file_utils.py causes circular import when launching ovos_dinkum_listener
1 participant