Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup deprecation logs #164

Merged
merged 6 commits into from
Jun 15, 2023
Merged

Cleanup deprecation logs #164

merged 6 commits into from
Jun 15, 2023

Conversation

NeonDaniel
Copy link
Member

Deprecation decorator was logging on import of deprecated methods. This adds handling to accurately log originating calls to deprecated methods without logging on import

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #164 (9d0b592) into dev (d76cda5) will increase coverage by 25.96%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             dev     #164       +/-   ##
==========================================
+ Coverage   0.00%   25.96%   +25.96%     
==========================================
  Files         49       49               
  Lines       6363     6367        +4     
==========================================
+ Hits           0     1653     +1653     
+ Misses      6363     4714     -1649     
Impacted Files Coverage Δ
ovos_utils/skills/audioservice.py 27.08% <ø> (+27.08%) ⬆️
ovos_utils/version.py 0.00% <0.00%> (ø)
ovos_utils/log.py 83.08% <100.00%> (+83.08%) ⬆️

... and 31 files with indirect coverage changes

@NeonDaniel NeonDaniel marked this pull request as ready for review June 15, 2023 00:20
@NeonDaniel NeonDaniel requested a review from a team June 15, 2023 00:21
@JarbasAl JarbasAl merged commit dfe8d86 into dev Jun 15, 2023
@JarbasAl JarbasAl deleted the FIX_ExtraDeprecationLogs branch June 15, 2023 00:25
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants