Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compat. with pages2uri extra_directories #162

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

NeonDaniel
Copy link
Member

Fixes bug introduced in #140

ovos_utils/gui.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #162 (8a3e6a1) into dev (0e176f6) will increase coverage by 25.89%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             dev     #162       +/-   ##
==========================================
+ Coverage   0.00%   25.89%   +25.89%     
==========================================
  Files         49       49               
  Lines       6360     6360               
==========================================
+ Hits           0     1647     +1647     
+ Misses      6360     4713     -1647     
Impacted Files Coverage Δ
ovos_utils/version.py 0.00% <0.00%> (ø)
ovos_utils/gui.py 37.81% <50.00%> (+37.81%) ⬆️

... and 32 files with indirect coverage changes

@JarbasAl JarbasAl added the bug Something isn't working label Jun 14, 2023
@JarbasAl JarbasAl merged commit a2dc68e into dev Jun 14, 2023
@JarbasAl JarbasAl deleted the FIX_ExtraDirectoriesCompat branch June 14, 2023 00:30
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants