Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate GUI Module and refactor resource resolution #158

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

NeonDaniel
Copy link
Member

@NeonDaniel NeonDaniel commented Jun 8, 2023

Continuation of #157
Cleanup docstrings and type annotations in gui module
Refactor so resources from GUI plugins take priority over core resources

@NeonDaniel NeonDaniel requested a review from JarbasAl June 8, 2023 23:26
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #158 (c76b359) into dev (57f7909) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff           @@
##             dev    #158    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files         47      49     +2     
  Lines       5482    6330   +848     
======================================
- Misses      5482    6330   +848     
Impacted Files Coverage Δ
ovos_utils/__init__.py 0.00% <0.00%> (ø)
ovos_utils/bracket_expansion.py 0.00% <0.00%> (ø)
ovos_utils/configuration.py 0.00% <0.00%> (ø)
ovos_utils/device_input.py 0.00% <0.00%> (ø)
ovos_utils/dialog.py 0.00% <0.00%> (ø)
ovos_utils/enclosure/__init__.py 0.00% <0.00%> (ø)
ovos_utils/enclosure/api.py 0.00% <0.00%> (ø)
ovos_utils/events.py 0.00% <0.00%> (ø)
ovos_utils/file_utils.py 0.00% <0.00%> (ø)
ovos_utils/fingerprinting.py 0.00% <0.00%> (ø)
... and 27 more

@JarbasAl JarbasAl added the documentation Improvements or additions to documentation label Jun 8, 2023
@NeonDaniel NeonDaniel marked this pull request as draft June 9, 2023 00:34
@NeonDaniel NeonDaniel changed the title Cleanup docstrings and type annotations in gui module Annotate GUI Module and refactor resource resolution Jun 9, 2023
@NeonDaniel NeonDaniel marked this pull request as ready for review June 9, 2023 01:29
@JarbasAl JarbasAl added the bug Something isn't working label Jun 9, 2023
@JarbasAl JarbasAl merged commit 72973b7 into dev Jun 9, 2023
@JarbasAl JarbasAl deleted the DOC_UpdateGuiModuleDocstrings branch June 9, 2023 01:30
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants