Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test coverage for SkillApi #145

Merged
merged 3 commits into from
May 31, 2023

Conversation

NeonDaniel
Copy link
Member

Add basic unit test coverage for SkillApi class with TODO for remaining tests

@NeonDaniel NeonDaniel requested a review from a team May 22, 2023 21:34
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #145 (0e63de5) into dev (57f7909) will increase coverage by 10.75%.
The diff coverage is 25.85%.

@@            Coverage Diff             @@
##             dev     #145       +/-   ##
==========================================
+ Coverage   0.00%   10.75%   +10.75%     
==========================================
  Files         47       78       +31     
  Lines       5482     7078     +1596     
==========================================
+ Hits           0      761      +761     
- Misses      5482     6317      +835     
Impacted Files Coverage Δ
ovos_utils/__init__.py 0.00% <0.00%> (ø)
ovos_utils/bracket_expansion.py 0.00% <0.00%> (ø)
ovos_utils/configuration.py 0.00% <0.00%> (ø)
ovos_utils/device_input.py 0.00% <0.00%> (ø)
ovos_utils/dialog.py 0.00% <0.00%> (ø)
ovos_utils/enclosure/__init__.py 0.00% <0.00%> (ø)
ovos_utils/enclosure/api.py 0.00% <0.00%> (ø)
ovos_utils/events.py 0.00% <0.00%> (ø)
ovos_utils/file_utils.py 0.00% <0.00%> (ø)
ovos_utils/fingerprinting.py 0.00% <0.00%> (ø)
... and 56 more

@JarbasAl JarbasAl changed the title Add unit test coverage for code added since last stable version Add unit test coverage for SkillApi May 31, 2023
@JarbasAl JarbasAl merged commit c11e9e9 into OpenVoiceOS:dev May 31, 2023
@github-actions github-actions bot mentioned this pull request Jun 1, 2023
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants