Add logging when an Api method return is missing or invalid

OpenVoiceOS · Jun 29, 2023 · c12354a · c12354a
1 parent 1bb5043
commit c12354a
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/ovos_utils/skills/api.py b/ovos_utils/skills/api.py
@@ -14,6 +14,7 @@
 
 from typing import Dict, Optional
 from ovos_bus_client.message import Message
+from ovos_utils.log import LOG
 
 
 class SkillApi:
@@ -49,11 +50,13 @@ def method(*args, **kwargs):
                     response = \
                         SkillApi.bus.wait_for_response(method_msg,
                                                        timeout=self.timeout)
-                    if (response and response.data and
-                            'result' in response.data):
-                        return response.data['result']
-                    else:
+                    if not response:
+                        LOG.error(f"Timed out waiting for {method_msg}")
                         return None
+                    elif 'result' not in response.data:
+                        LOG.error(f"missing `result` in: {response.data}")
+                    else:
+                        return response.data['result']
 
                 return method