-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support ovos-translate-server #182
Comments
The mappings in the factory methods are mostly for backwards-compat. This plugin should be loaded if the entrypoint (ovos-translate-plugin-server) is specified in config Did you see either of these logs?
|
On another read, the |
indeed, the detection module is not used directly in any major OVOS component, and when used it is optional translation is the major component we support, for detection the default config points to the very basic lang detector provided by ovos-classifiers, just to ensure something loads if the factory is called, however it is strongly recommended users pick a different lang detector, such as cld3 that runs offline. we just dont want to drag additional dependencies as a default value note the translation server does support both endpoints, so it would also be valid to get a remote lang detection server list in the plugin, and migrate the official ovos server to use something like cld3 (or better), the official ovos server / nllb docker image is using https://github.com/OpenVoiceOS/lingua-podre/ for language detection outdated list of plugins here https://openvoiceos.github.io/ovos-technical-manual/lang_plugins/
|
Update config handling to special-case `translation_module` and `detection_module` Abstract default plugins to private variables for better testing/readability Relates to #182
Update config handling to special-case `translation_module` and `detection_module` Abstract default plugins to private variables for better testing/readability Relates to #182
fixed by #184 |
Support for ovos-translate-server-plugin is missing from
OVOSLangDetectionFactory
's mappings. This caused almost entirely indecipherable failures in some tests in the icanhazdadjokes skill, which had recently been adjusted to us ovos-translate-server, but was silently failing over to Neon's libretranslate plugin. When I removed that plugin from requirements.txt because it was theoretically not needed, all the tests failed.Adding support for
ovos-translate-server
means that the joking skill, and any others usingOVOSLangDetectionFactory
, can start using it.The text was updated successfully, but these errors were encountered: