Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playlists don't work when progressing naturally, but skips are fine #123

Closed
mikejgray opened this issue Aug 5, 2024 · 3 comments · Fixed by OpenVoiceOS/ovos-audio-plugin-mpv#6
Closed

Playlists don't work when progressing naturally, but skips are fine #123

mikejgray opened this issue Aug 5, 2024 · 3 comments · Fixed by OpenVoiceOS/ovos-audio-plugin-mpv#6
Assignees
@JarbasAl
Labels
bug Something isn't working

Comments

@mikejgray
Copy link

Playlists work if I don't let a track finish. For example, I can skip to the next track, see all the tracks, etc, but when I finish listening to one song it shows:

2024-08-04 20:51:48.319 - audio - ovos_audio.audio:track_start:210 - DEBUG - New track coming up!
...snip
2024-08-04 20:55:38.563 - audio - ovos_audio.audio:track_start:217 - DEBUG - End of playlist!
@JarbasAl JarbasAl self-assigned this Aug 5, 2024
@JarbasAl JarbasAl added the bug Something isn't working label Aug 5, 2024
@mikejgray
Copy link
Author

Confirmed on both my Mac and on my Mark 1 (Pi 4 hacked upgrade)

@goldyfruit
Copy link
Member

Same here. The playlist stopped after the first song finishes.

JarbasAl added a commit to OpenVoiceOS/ovos-audio-plugin-mpv that referenced this issue Aug 6, 2024
@JarbasAl
fix/end_of_track
b2817c9 
closes OpenVoiceOS/ovos-ocp-audio-plugin#123
@JarbasAl JarbasAl mentioned this issue Aug 6, 2024
Merged
JarbasAl added a commit that referenced this issue Aug 6, 2024
@JarbasAl
logs/end_of_track
d04b96c 
make it easier to debug issues like  #123
@JarbasAl JarbasAl mentioned this issue Aug 6, 2024
Merged
JarbasAl added a commit that referenced this issue Aug 6, 2024
@JarbasAl
logs/end_of_track (#124)
b8f5202 
make it easier to debug issues like  #123
@mikejgray
Copy link
Author

Fixed!

@github-actions github-actions bot mentioned this issue Sep 2, 2024
Merged
JarbasAl added a commit that referenced this issue Sep 3, 2024
@github-actions @NeonJarbas @JarbasAl
0.0.7 (#126)
49bde43 
* refactor/utils_0.1.0 (#108)

* refactor/utils_0.1.0

* opm imports

* no create .desktop file

* no create .desktop file

* requirements

* requirements

---------

Co-authored-by: JarbasAi <jarbasai@mailfence.com>

* Increment Version to 0.0.7a1

* Update Changelog

* refactor/dry_ocp_imports (#109)

* refactor/dry_ocp_imports

import Playlist and MediaEntry objects from utils 0.1.0

* tests

* tests

* fix/ocp_playlist

allow initing Playlist object as a regular list

---------

Co-authored-by: JarbasAi <jarbasai@mailfence.com>

* Increment Version to 0.0.7a2

* Update Changelog

* feat/experimental_ocp_pipeline (#112)

allow using Classic OCP with the new pipeline

companion to OpenVoiceOS/ovos-core#456

* Increment Version to 0.0.7a3

* Update Changelog

* fix/coexistence_with_pipeline (#115)

* fix/coexistence_with_pipeline

intents were being registered even if pipeline enabled, only the media matchers were taking into account the new flag

this commit moves the check to init instead

* port/SEI report event

report plugins to ovos-core like ovos-media does to help in transition

* fix stop

* Increment Version to 0.0.7a4

* Update Changelog

* fix/playlist handling (#116)

* fix deprecation warnings

* fix type checks

* better log

* support older ovos-utils

* type checking fixes

* typing

* yeah

* Increment Version to 0.0.7a5

* Update Changelog

* fix/playlist_again (#117)

* Increment Version to 0.0.7a6

* Update Changelog

* default to OCP pipeline + support for utils 0.0.38 (#119)

* remove dead code

since OpenVoiceOS/ovos-core#491 and OpenVoiceOS/ovos-config#96 this is effectively dead code

all NLP matching is dropped in this PR

* rm dead code

* drop old tests

* Increment Version to 0.0.7a7

* Update Changelog

* fix/native_sources (#120)

* fix/native_sources

allow usage with voice satellites, without triggering playback on master side

similar to what classic audio service does, but with a decorator to make it more usable

* handle message=None

* fix backend check

* kwarg

* add helper property

* message None

* default val

* missing kwarg

* drop old classifier tests

* drop old classifier tests

* keep your crappy test

* keep your crappy test

* a relevant test now

* Increment Version to 0.0.7a8

* Update Changelog

* fix/play_from_gui (#121)

* fix/play_from_gui

when selecting entries from featured media PluginStream was not being recognized

if audio restarts with GUI opening, playback would fail due to GUI sending malformed data, this commit also works around that issue

* more fixes

* more fixes

* update tests

* restore tst

* keep old OCP bugs around 👍

* fixy fixes

* Increment Version to 0.0.7a9

* Update Changelog

* fix/playlist_handling (#122)

* fix/playlist_handling

fix position of "now playing" handling

fix PluginStream to MediaEntry extraction

fix Playlist of PluginStream

* deprecate extract_stream

* check bounds of idx

* remove test for old ovos-audio version

compat with utils 0.0.38

* fix tests

* Increment Version to 0.0.7a10

* Update Changelog

* Update README.md

* logs/end_of_track (#124)

make it easier to debug issues like  #123

* Increment Version to 0.0.7a11

* Update Changelog

* Increment Version to 0.0.7

* Update Changelog

---------

Co-authored-by: NeonJarbas <59943014+NeonJarbas@users.noreply.github.com>
Co-authored-by: JarbasAi <jarbasai@mailfence.com>
Co-authored-by: JarbasAl <JarbasAl@users.noreply.github.com>
Co-authored-by: JarbasAI <33701864+JarbasAl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JarbasAl JarbasAl

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix/end_of_track OpenVoiceOS/ovos-audio-plugin-mpv
3 participants
@goldyfruit @mikejgray @JarbasAl