Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor/play_sound_in_ovos_audio #60

Merged
merged 7 commits into from
Sep 8, 2023
Merged

refactor/play_sound_in_ovos_audio #60

merged 7 commits into from
Sep 8, 2023

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Sep 6, 2023

@JarbasAl JarbasAl added the refactor code improvements with no functional changes label Sep 6, 2023
@JarbasAl JarbasAl requested review from goldyfruit, NeonDaniel and a team September 6, 2023 00:09
@JarbasAl JarbasAl mentioned this pull request Sep 6, 2023
Merged
@JarbasAl JarbasAl mentioned this pull request Sep 6, 2023
Closed
@goldyfruit
Copy link
Member

Tested and got the start_listening.wav sound played from ovos_audio container.

2023-09-07 16:54:57.946 - audio - ovos_workshop.skills.base:is_classic_core:85 - WARNING - Deprecation version=0.1.0. Caller=ovos_workshop.skills.mycroft_skill:207. Support for `mycroft_core` will be deprecated
Playing WAVE '/home/ovos/.venv/lib/python3.11/site-packages/ovos_audio/res/snd/start_listening.wav' : Signed 16 bit Little Endian, Rate 48000 Hz, Stereo
2023-09-07 16:55:06.987 - audio - ovos_workshop.skills.base:is_classic_core:85 - WARNING - Deprecation version=0.1.0. Caller=ovos_workshop.skills.mycroft_skill:207. Support for `mycroft_core` will be deprecated
2023-09-07 16:55:07.180 - audio - ovos_workshop.skills.base:is_classic_core:85 - WARNING - Deprecation version=0.1.0. Caller=ovos_workshop.skills.mycroft_skill:207. Support for `mycroft_core` will be deprecated
2023-09-07 16:55:07.181 - audio - ovos_workshop.skills.base:is_classic_core:85 - WARNING - Deprecation version=0.1.0. Caller=ovos_workshop.skills.mycroft_skill:207. Support for `mycroft_core` will be deprecated
2023-09-07 16:55:09.334 - audio - ovos_audio.service:handle_instant_play:422 - DEBUG - ignoring playback, message is not from a native source

@JarbasAl JarbasAl merged commit 4411361 into dev Sep 8, 2023
9 checks passed
@JarbasAl JarbasAl deleted the refactor/play_sound_in_ovos_audio branch September 8, 2023 17:57
@JarbasAl JarbasAl mentioned this pull request Oct 18, 2023
Closed
JarbasAl added a commit that referenced this pull request Nov 24, 2023
@JarbasAl
refactor/play_sound_in_ovos_audio (#60)
dad2f9b
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeonDaniel NeonDaniel NeonDaniel left review comments

@goldyfruit goldyfruit Awaiting requested review from goldyfruit

Assignees
No one assigned
Labels
refactor code improvements with no functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JarbasAl @goldyfruit @NeonDaniel