Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acquire lock during service shutdown to prevent reload race condition #39

Merged
merged 1 commit into from
May 31, 2023

Conversation

NeonDaniel
Copy link
Member

Troubleshooting logged exception:

2023-05-30 15:32:48.353 - voice - ovos_dinkum_listener.service:reload_configuration:866 - INFO - Reloading Listener
2023-05-30 15:32:48.479 - voice - ovos_dinkum_listener.service:run:263 - ERROR - voice_loop failed
Traceback (most recent call last):
  File "/home/neon/venv/lib/python3.7/site-packages/ovos_dinkum_listener/service.py", line 259, in run
    self.voice_loop.run()
  File "/home/neon/venv/lib/python3.7/site-packages/ovos_dinkum_listener/voice_loop/voice_loop.py", line 182, in run
    assert chunk is not None, "No audio from microphone"
AssertionError: No audio from microphone
2023-05-30 15:32:48.487 - voice - ovos_dinkum_listener.service:run:266 - INFO - Service stopping
2023-05-30 15:32:48.640 - voice - ovos_dinkum_listener.service:run:272 - ERROR - Service failed to start
Traceback (most recent call last):
  File "/home/neon/venv/lib/python3.7/site-packages/ovos_dinkum_listener/service.py", line 268, in run
    self._shutdown()
  File "/home/neon/venv/lib/python3.7/site-packages/ovos_dinkum_listener/service.py", line 353, in _shutdown
    self.mic.stop()
AttributeError: 'NeonSpeechClient' object has no attribute 'mic'

@NeonDaniel NeonDaniel requested a review from JarbasAl May 30, 2023 23:07
@NeonDaniel NeonDaniel marked this pull request as ready for review May 30, 2023 23:07
@JarbasAl JarbasAl added the bug Something isn't working label May 31, 2023
@JarbasAl JarbasAl merged commit 105f1c1 into dev May 31, 2023
@JarbasAl JarbasAl deleted the FIX_ShutdownExceptions branch May 31, 2023 14:09
@github-actions github-actions bot mentioned this pull request Jun 5, 2023
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants