fix/reranker_config

[JarbasAl]

config was not being passed to reranker plugin

Summary by CodeRabbit

• New Features

  • Enhanced flexibility for the reranker initialization with configuration options for improved performance.

• Bug Fixes

  • Improved behavior of the reranker module through better configuration handling.

[coderabbitai]

Walkthrough

The recent changes enhance the initialization of the reranker in the CommonQAService class, allowing it to be configured using a settings dictionary. This update improves flexibility and performance by tailoring the reranker setup to specific requirements, although the overall control flow remains unchanged.

Changes

Files	Change Summary
ovos_core/intent_services/commonqa_service.py	Modified the initialization of the reranker to include configuration options from the config dictionary.

Poem

🐰 In the code where rabbits roam,
A reranker found its new home.
With configs set, it hops with glee,
Improved and swift as it can be!
Now every query's met with cheer,
A smarter helper, always near! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0a48006 and 5893e8f.

Files selected for processing (1)

• ovos_core/intent_services/commonqa_service.py (1 hunks)

Additional comments not posted (7)

ovos_core/intent_services/commonqa_service.py (7)

52-52: Ensure proper handling of the configuration for the reranker plugin.

The code changes correctly pass the configuration to the reranker plugin, enhancing its flexibility. Ensure that the configuration dictionary is correctly structured and contains the necessary settings for the reranker plugin.

---

Line range hint 34-39:
LGTM!

The handle_skill_pong method is consistent with the rest of the file.

---

Line range hint 41-53:
LGTM!

The is_question_like method is consistent with the rest of the file.

---

Line range hint 55-97:
LGTM!

The match method is consistent with the rest of the file.

---

Line range hint 99-136:
LGTM!

The handle_question method is consistent with the rest of the file.

---

Line range hint 138-193:
LGTM!

The handle_query_response method is consistent with the rest of the file.

---

Line range hint 195-261:
LGTM!

The _query_timeout method is consistent with the rest of the file.

[JarbasAl]

example

"common_query": {
      "reranker": "ovos-flashrank-reranker-plugin",
      "ignore_skill_scores": true,
      "ovos-flashrank-reranker-plugin": {"model": "ms-marco-TinyBERT-L-2-v2"}
}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.37%. Comparing base (3208daa) to head (5893e8f).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@           Coverage Diff           @@
##              dev     #532   +/-   ##
=======================================
  Coverage   75.37%   75.37%           
=======================================
  Files          15       15           
  Lines        3086     3086           
=======================================
  Hits         2326     2326           
  Misses        760      760           

Flag	Coverage Δ
unittests	75.37% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.