Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/legacy_play #514

Merged
merged 2 commits into from
Jun 21, 2024
Merged

fix/legacy_play #514

merged 2 commits into from
Jun 21, 2024

Conversation

JarbasAl
Copy link
Member

handle Playlist objects

use helper methods to parse the ocp stream from PluginStream objects

needs OpenVoiceOS/ovos-utils#257

handle Playlist objects

use helper methods to parse the ocp stream from PluginStream objects

needs OpenVoiceOS/ovos-utils#257
@JarbasAl JarbasAl added the bug Something isn't working label Jun 21, 2024
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.88%. Comparing base (a3aa6f1) to head (e789218).
Report is 1 commits behind head on dev.

Files Patch % Lines
ovos_core/intent_services/ocp_service.py 61.53% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #514      +/-   ##
==========================================
- Coverage   75.97%   75.88%   -0.10%     
==========================================
  Files          15       15              
  Lines        3018     3027       +9     
==========================================
+ Hits         2293     2297       +4     
- Misses        725      730       +5     
Flag Coverage Δ
unittests 75.88% <61.53%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit 1535a7e into dev Jun 21, 2024
7 of 8 checks passed
@JarbasAl JarbasAl deleted the fix/legacy_play branch June 21, 2024 18:01
@JarbasAl JarbasAl added this to the 0.0.8 milestone Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant