improve_fallback_timeout #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improves #389 but does not fix it allow up to 15 seconds by default for each fallback skill (previously 3) + make configurable log warnings on timeout
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #506 +/- ##
==========================================
+ Coverage 73.62% 73.67% +0.05%
==========================================
Files 15 15
Lines 3207 3210 +3
==========================================
+ Hits 2361 2365 +4
+ Misses 846 845 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
by using a killable_event we can abort fallbacks that timedout avoiding multiple answers closes #389 needs OpenVoiceOS/OVOS-workshop#210
JarbasAl
commented
Jun 18, 2024
| fallbacks = [(k, v) for k, v in self.registered_fallbacks.items() | ||
| if k in self._collect_fallback_skills(message, fb_range)] |
There was a problem hiding this comment.
NOTE for reviewers: this would repeat the ping/pong bus message pattern once per skill, it can't be used inside the iterator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #389
"max_skill_runtime": 10for reference, the killable_events decorator is tested here https://github.com/OpenVoiceOS/ovos-core/blob/dev/test/integrationtests/test_workshop.py#L83