fix/ocp_per_session #495
Merged
fix/ocp_per_session #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracks available stream extractors per session, this allows running OCP in the HiveMind satellite side
tracks available stream extractors per session, this allows running OCP in the HiveMind satellite side
JarbasAl
added a commit
to JarbasHiveMind/HiveMind-core
that referenced
this pull request
Jun 5, 2024
companion to OpenVoiceOS/ovos-core#495 makes voice sats able to report what stream extractor plugins they have installed for usage with OCP without needing to explicit whitelist the bus message
JarbasAl
added a commit
to JarbasHiveMind/HiveMind-core
that referenced
this pull request
Jun 5, 2024
companion to OpenVoiceOS/ovos-core#495 makes voice sats able to report what stream extractor plugins they have installed for usage with OCP without needing to explicit whitelist the bus message
to better track and encapsulate session info in a more scalable way
|
this quickly identified some extra issues around session support, marked as draft until i solve those the player/media state also needs to take session into account |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #495 +/- ##
==========================================
+ Coverage 73.18% 73.36% +0.17%
==========================================
Files 15 15
Lines 3051 3101 +50
==========================================
+ Hits 2233 2275 +42
- Misses 818 826 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracks available stream extractors per session, this allows running OCP satellite side