-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Troubleshoot transformers test failures #487
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #487 +/- ##
==========================================
+ Coverage 74.61% 74.97% +0.35%
==========================================
Files 15 15
Lines 2821 2821
==========================================
+ Hits 2105 2115 +10
+ Misses 716 706 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -6,5 +8,5 @@ class MetadataPlugin(MetadataTransformer): | |||
def __init__(self, name="ovos-metadata-test-plugin", priority=15): | |||
super().__init__(name, priority) | |||
|
|||
def transform(self, context: dict | None = None) -> dict: | |||
def transform(self, context: Optional[dict] = None) -> dict: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, so it was failing because of python version here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably; I forget when that syntax was added, but presumably 3.10 or 3.11 based on the failure
Continues #486