refactor/pipeline_shutdown #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds shutdown method to pipeline components, allowing to deregister bus events etc removes fallback V1 pipeline, that was only to help in transition, ovos-workshop only uses fallbackV1 if it detects ovos-core <= 0.0.7 it is impossible to use with ovos-core 0.0.8 in a natural way, standalone skills were introduced in core 0.0.8 and also use V2 see https://github.com/OpenVoiceOS/OVOS-workshop/blob/dev/ovos_workshop/skills/fallback.py#L74 when used, it only introduces 10 seconds latency for no good reason streamlines main.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #484 +/- ##
==========================================
+ Coverage 73.46% 74.54% +1.08%
==========================================
Files 15 15
Lines 2762 2833 +71
==========================================
+ Hits 2029 2112 +83
+ Misses 733 721 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds shutdown method to pipeline components, allowing to deregister bus events etc
removes fallback V1 pipeline, that was only to help in transition, ovos-workshop only uses fallbackV1 if it detects ovos-core <= 0.0.7 it is impossible to use with ovos-core 0.0.8 in a natural way, standalone skills were introduced in core 0.0.8 and also use V2
see https://github.com/OpenVoiceOS/OVOS-workshop/blob/dev/ovos_workshop/skills/fallback.py#L74
when used, it only introduces 10 seconds latency for no good reason
streamlines main.py