feat/legacy_common_play #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restore support for Mycroft CommonPlay skills
enable with
```json
{
"intents": {
"legacy_cps": true,
"pipelines": ["...", "ocp_legacy"]
}
}
```
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #457 +/- ##
==========================================
+ Coverage 73.09% 73.58% +0.48%
==========================================
Files 15 15
Lines 2661 2733 +72
==========================================
+ Hits 1945 2011 +66
- Misses 716 722 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JarbasAl
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restore support for Mycroft CommonPlay skills
enable with
{ "intents": { "legacy_cps": true, "pipelines": ["...", "ocp_legacy"] } }continuation of #456 and #420
you got that right, old CommonPlay skills will work for 0.0.8