fix/deactivate inside intent/converse

[JarbasAl]

closes #450

needs OpenVoiceOS/OVOS-workshop#198

CAVEATS:

• self.deactivate() can now be called inside intent handlers
• self.deactivate() can now be called inside converse handlers, but ONLY if they return False
• self.deactivate() can now be called inside fallback handlers, but ONLY if they return False

if converse/fallback returns True (to consume the utterance) the skill is reactivated right after the handler

if you need to deactivate a skill and also consume the utterance, then you need to use the callback instead

class MySkill(OVOSSkill):
    def converse(self, message):  # or fallback skill handler
        self.do_deactivation = True
        return True

    def handle_activate(self, message: Message):
		"""called after converse return True (but not False)"""
        if self.do_deactivation:
			self.deactivate()
       	self.do_deactivation = False

solving this limitation will require deeper changes in ovos-workshop and is not a trivial fix, a test case is included with a TODO

expected_messages = [
    "recognizer_loop:utterance", # converse gets it
    f"{self.skill_id}.converse.ping",
    "skill.converse.pong",
    f"{self.skill_id}.converse.request",
    # converse code
    "intent.service.skills.deactivate",
    "intent.service.skills.deactivated",
    f"{self.skill_id}.deactivate",
    "ovos.session.update_default",
    ###########
    # TODO - activate is called here if converse return True
    "intent.service.skills.activate",
    "intent.service.skills.activated",
    f"{self.skill_id}.activate",
    "ovos.session.update_default",
    # /TODO - ovos-workshop PR needed
    ###########
    "skill.converse.response",  # conversed!
    # session updated
    "ovos.session.update_default"
]

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 66.70%. Comparing base (b68a70d) to head (a6e3826).
Report is 1 commits behind head on dev.

Files	Patch %	Lines
ovos_core/intent_services/ocp_service.py	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #451      +/-   ##
==========================================
- Coverage   66.70%   66.70%   -0.01%     
==========================================
  Files          15       15              
  Lines        2607     2610       +3     
==========================================
+ Hits         1739     1741       +2     
- Misses        868      869       +1     

Flag	Coverage Δ
unittests	66.70% <75.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.