Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen ovos-bus-client dependency to allow ovos-utils 0.0.X #448

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

NeonDaniel
Copy link
Member

Add test dependency to allow for OCP intent service tests
Closes #447

Add test dependency to allow for OCP intent service tests
@NeonDaniel
Copy link
Member Author

Needs dependency update after OpenVoiceOS/ovos-listener#28 to resolve resolution error

@NeonDaniel
Copy link
Member Author

Tests failing with ovos-stt-plugin-selene 0.0.3a3 depends on ovos-utils~=0.0.8

selene plugin needs updating to allow ovos-utils 0.1 or be refactored out of test dependencies

@JarbasAl
Copy link
Member

Tests failing with ovos-stt-plugin-selene 0.0.3a3 depends on ovos-utils~=0.0.8

selene plugin needs updating to allow ovos-utils 0.1 or be refactored out of test dependencies

that plugin is deprecated and archived, selene is not supported anymore either, so let's remove it from tests

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.70%. Comparing base (f147cf3) to head (f4e7101).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #448   +/-   ##
=======================================
  Coverage   66.70%   66.70%           
=======================================
  Files          15       15           
  Lines        2607     2607           
=======================================
  Hits         1739     1739           
  Misses        868      868           
Flag Coverage Δ
unittests 66.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NeonDaniel NeonDaniel marked this pull request as ready for review April 26, 2024 01:11
@NeonDaniel NeonDaniel requested a review from a team April 26, 2024 01:11
@JarbasAl JarbasAl merged commit b68a70d into dev Apr 26, 2024
9 checks passed
@JarbasAl JarbasAl deleted the FIX_OvosUtils0.0.xCompat branch April 26, 2024 01:21
@JarbasAl JarbasAl added this to the 0.0.8 milestone May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add back ovos-utils 0.0.X support
2 participants