refactor/reduce code complexity #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #427 +/- ##
==========================================
- Coverage 63.99% 63.98% -0.01%
==========================================
Files 15 15
Lines 2580 2585 +5
==========================================
+ Hits 1651 1654 +3
- Misses 929 931 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
extract an helper method from the utterance handler to improve readibility and reduce code complexity handle the case where a pipeline plugin returns a bad intent match object
extract an helper method from the utterance handler to improve readibility and reduce code complexity handle the case where a pipeline plugin returns a bad intent match object
JarbasAl
force-pushed
the
refactor/reduce_code_complexity
branch
from
6a682d3
to
93aec67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extract an helper method from the utterance handler to improve readibility and reduce code complexity
handle the case where a pipeline plugin returns a bad intent match object