Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deregister any entities when a skill is detached. Fixes #394 #395

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

lbt
Copy link

@lbt lbt commented Jan 5, 2024

No description provided.

@JarbasAl JarbasAl added the bug Something isn't working label Jan 5, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (835ac34) 60.90% compared to head (a96013a) 60.83%.
Report is 9 commits behind head on dev.

❗ Current head a96013a differs from pull request most recent head 0154c34. Consider uploading reports for the commit 0154c34 to get more accurate results

Files Patch % Lines
ovos_core/intent_services/padacioso_service.py 50.00% 6 Missing ⚠️
ovos_core/intent_services/adapt_service.py 60.00% 2 Missing ⚠️
ovos_core/intent_services/padatious_service.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #395      +/-   ##
==========================================
- Coverage   60.90%   60.83%   -0.08%     
==========================================
  Files          13       13              
  Lines        1857     1879      +22     
==========================================
+ Hits         1131     1143      +12     
- Misses        726      736      +10     
Flag Coverage Δ
unittests 60.83% <58.33%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: David Greaves <david@dgreaves.com>
@lbt
Copy link
Author

lbt commented Jan 5, 2024

Depends on OpenVoiceOS/OVOS-workshop#171

@JarbasAl JarbasAl merged commit d899113 into OpenVoiceOS:dev Jan 8, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants