Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unittests/get_response_return_val #362

Merged
merged 3 commits into from
Oct 2, 2023
Merged

unittests/get_response_return_val #362

merged 3 commits into from
Oct 2, 2023

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Oct 2, 2023

@JarbasAl JarbasAl added bug Something isn't working tests and automation added unittests or github workflows labels Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9a3a92d) 60.23% compared to head (0d74824) 60.23%.
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev     #362   +/-   ##
=======================================
  Coverage   60.23%   60.23%           
=======================================
  Files          13       13           
  Lines        1851     1851           
=======================================
  Hits         1115     1115           
  Misses        736      736
Flag Coverage Δ
unittests 60.23% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ovos_core/version.py 76.92% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl marked this pull request as ready for review October 2, 2023 23:50
@JarbasAl JarbasAl merged commit b548c2d into dev Oct 2, 2023
10 checks passed
@JarbasAl JarbasAl deleted the fix/get_response branch October 2, 2023 23:51
@JarbasAl JarbasAl changed the title fix/get_response some more unittests/get_response_return_val Oct 3, 2023
@JarbasAl JarbasAl mentioned this pull request Oct 3, 2023
Closed
@JarbasAl JarbasAl added the packaging dependency updates or packaging changes label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working packaging dependency updates or packaging changes tests and automation added unittests or github workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JarbasAl