refactor/padatious_samples #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #309 +/- ##
===========================================
- Coverage 50.35% 12.45% -37.90%
===========================================
Files 119 10 -109
Lines 10077 1397 -8680
===========================================
- Hits 5074 174 -4900
+ Misses 5003 1223 -3780 |
|
Even with this PR, I'm still not able to have the personal skill working. From core logs: From the personal skill log: |
|
Some intents as well are not working, for example: "what is the temperature" works but "Do I need an umbrella" does not. |
|
also needs OpenVoiceOS/OVOS-workshop#66 |
Does it needs to run with core or with the skill? |
|
ovos_workshop needs to be updated in the skill, this will emit the new optional data with all samples on the bus instead of filepath ovos-core needs to also be updated to actually consume those samples |
When I install the PR 66 into the skill container I got this. |
fixed now OpenVoiceOS/OVOS-workshop#66 |
JarbasAl
added a commit
to OpenVoiceOS/ovos-utils
that referenced
this pull request
Apr 24, 2023
companion to OpenVoiceOS/ovos-core#309
JarbasAl
added a commit
to OpenVoiceOS/ovos-utils
that referenced
this pull request
Apr 24, 2023
companion to OpenVoiceOS/ovos-core#309
Closed
JarbasAl
force-pushed
the
refactor/padatious_samples
branch
from
6675ffc
to
3349034
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
padatious accepted a file path in the bus message registering intents, this causes issues when using skills standalone via ovos-workshop SkillContainer, the file is not assured to exist in ovos-core
this adds support for messages to send the samples directly, a companion PR in ovos workshop will update the emitted message
backwards compat is maintained with no version sync needed