add platform-requirements to not include any base skill installs #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 10, 2023
Closed
|
as discussed in chat this misunderstands how requirements work in ovos-core what brought this up was the inclusion of homescreen and setup skill, which should be removed from the requirements list as these are platform specific, but the deeper issue is around our packaging and should be handled in #264 as part of #274 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add platform-requirements.txt and ["platform"] egg for platforms where no default skills should be included, as platform / distributions can choose and pick what defaults to install and package.
Fixes planned 0.0.7 breaks platforms and distribution packaging. #276