-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/queue_audio #180
feat/queue_audio #180
Conversation
allow to queue audio files for playback via messagebus this ensures they are played between TTS and not over it future work can be done to support the SSML audio tag in all engines using this functionality
Codecov Report
@@ Coverage Diff @@
## dev #180 +/- ##
==========================================
+ Coverage 50.35% 52.92% +2.57%
==========================================
Files 119 152 +33
Lines 10077 9510 -567
==========================================
- Hits 5074 5033 -41
+ Misses 5003 4477 -526
Continue to review full report at Codecov.
|
32197d5
to
c5c4d02
Compare
companion PR for OpenVoiceOS/ovos-core#180
companion PR for OpenVoiceOS/ovos-core#180
Just a note that sending audio file paths will not work under Neon Docker containers as the FS isn't shared. Will probably override in neon_audio to accept b64-encoded files as well as paths, but probably out of scope for this PR |
can send a follow up PR for that, don't mind adding native support for b64 under an optional different key and check for both. But this is worth further discussion as maybe it should live in ovos_workshop |
* feat/play_audio companion PR for OpenVoiceOS/ovos-core#180 * version * ovos-core >= 0.0.4a45 Co-authored-by: jarbasai <jarbasai@mailfence.com>
allow to queue audio files for playback via messagebus
this ensures they are played between TTS and not over it
future work can be done to support the SSML audio tag in all engines using this functionality