Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/queue_audio #180

Merged
merged 2 commits into from
Jul 28, 2022
Merged

feat/queue_audio #180

merged 2 commits into from
Jul 28, 2022

Conversation

NeonJarbas
Copy link

allow to queue audio files for playback via messagebus

this ensures they are played between TTS and not over it

future work can be done to support the SSML audio tag in all engines using this functionality

allow to queue audio files for playback via messagebus

this ensures they are played between TTS and not over it

future work can be done to support the SSML audio tag in all engines using this functionality
@JarbasAl JarbasAl requested a review from NeonDaniel July 28, 2022 16:49
@JarbasAl JarbasAl added the enhancement New feature or request label Jul 28, 2022
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #180 (c5c4d02) into dev (6ceb058) will increase coverage by 2.57%.
The diff coverage is 37.52%.

@@            Coverage Diff             @@
##              dev     #180      +/-   ##
==========================================
+ Coverage   50.35%   52.92%   +2.57%     
==========================================
  Files         119      152      +33     
  Lines       10077     9510     -567     
==========================================
- Hits         5074     5033      -41     
+ Misses       5003     4477     -526     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 138 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc6148a...c5c4d02. Read the comment docs.

@JarbasAl JarbasAl requested a review from NeonDaniel July 28, 2022 19:02
NeonJarbas pushed a commit to NeonJarbas/OVOS-workshop that referenced this pull request Jul 28, 2022
NeonJarbas pushed a commit to NeonJarbas/OVOS-workshop that referenced this pull request Jul 28, 2022
@NeonDaniel
Copy link
Member

Just a note that sending audio file paths will not work under Neon Docker containers as the FS isn't shared. Will probably override in neon_audio to accept b64-encoded files as well as paths, but probably out of scope for this PR

@JarbasAl
Copy link
Member

Just a note that sending audio file paths will not work under Neon Docker containers as the FS isn't shared. Will probably override in neon_audio to accept b64-encoded files as well as paths, but probably out of scope for this PR

can send a follow up PR for that, don't mind adding native support for b64 under an optional different key and check for both.

But this is worth further discussion as maybe it should live in ovos_workshop

@JarbasAl JarbasAl merged commit 4ccfd92 into OpenVoiceOS:dev Jul 28, 2022
JarbasAl added a commit to OpenVoiceOS/OVOS-workshop that referenced this pull request Jul 28, 2022
* feat/play_audio

companion PR for OpenVoiceOS/ovos-core#180

* version

* ovos-core >= 0.0.4a45

Co-authored-by: jarbasai <jarbasai@mailfence.com>
@NeonJarbas NeonJarbas deleted the feat/queue_audio branch January 6, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants