Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/remove_inflection_dep #17

Merged
merged 2 commits into from
Nov 10, 2021
Merged

refactor/remove_inflection_dep #17

merged 2 commits into from
Nov 10, 2021

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Nov 5, 2021

only used by 1 helper method rarely used in the first place, easily replaced by basic string operations

@JarbasAl JarbasAl added the refactor code refactor without functional changes label Nov 5, 2021
Copy link
Member

@NeonDaniel NeonDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test, looks good

@JarbasAl JarbasAl merged commit df94b4d into dev Nov 10, 2021
JarbasAl added a commit that referenced this pull request Nov 14, 2021
authored-by: jarbasai <jarbasai@mailfence.com>
@JarbasAl JarbasAl mentioned this pull request Nov 14, 2021
44 tasks
@JarbasAl JarbasAl deleted the refactor/inflection branch November 18, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor code refactor without functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants