Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with adapt service #417

Closed
Dante1975X opened this issue Feb 24, 2024 · 0 comments · Fixed by #418
Closed

Problems with adapt service #417

Dante1975X opened this issue Feb 24, 2024 · 0 comments · Fixed by #418
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Dante1975X
Copy link

As discussed last week in the matrix channel, in my ovos installation I have problems with the recognition of intents. The problems occure since the update of ovos-core to V0.0.8a67. Before that update everything was working right.

Not recognized are volume control commands like "louder", but only when a ocp skill is playing music. The same command is recognized when no music is playing. Also not rcognized are some (but not all) commands of the openhab skill.

Via trial and error I found out, that changing line 65 in adapt_service.py from self.conf_low = self.config.get("conf_low") or 0.5 to self.conf_low = self.config.get("conf_low") or 0.01 makes all working again.

I found no way of setting "conf_low" in mycroft.conf. Only changing the code directly helped.

@JarbasAl JarbasAl added the bug Something isn't working label Feb 24, 2024
JarbasAl added a commit that referenced this issue Feb 24, 2024
This was referenced Feb 24, 2024
@JarbasAl JarbasAl added this to the 0.0.8 milestone Feb 24, 2024
JarbasAl added a commit that referenced this issue Feb 24, 2024
maybe fixes #417

handle bad pipeline requests based on chat feedback

```
2024-02-24 18:20:09.365 - skills - ovos_core.transformers:transform:60 - DEBUG - ovos-utterance-normalizer: {'client_name': 'ovos_dinkum_listener', 'source': 'VoiceSatelliteV0.3.0:192.168.2.222::53c07e5b-e6a9-4467-bc5b-283842693997', 'destination': ['skills'], 'transcription': 'wie spät ist es', 'session': {'active_skills': [], 'utterance_states': {}, 'session_id': '53c07e5b-e6a9-4467-bc5b-283842693997', 'lang': 'en-us', 'context': {'timeout': 120, 'frame_stack': []}, 'site_id': 'unknown', 'pipeline': ['stop_high', 'converse', 'padatious_high', 'adapt_high', 'fallback_high', 'stop_medium', 'padatious_medium', 'adapt_medium', 'adapt_low', 'common_qa', 'fallback_medium', 'fallback_low'], 'stt': {'plugin_id': 'ovos-stt-plugin-server', 'config': {}}, 'tts': {'plugin_id': 'ovos-tts-plugin-server', 'config': {}}}, 'peer': 'VoiceSatelliteV0.3.0:192.168.2.222::53c07e5b-e6a9-4467-bc5b-283842693997', 'lang': 'de-de'}

2024-02-24 18:20:09.369 - skills - ovos_core.intent_services:handle_utterance:348 - ERROR - 'adapt_high'

Traceback (most recent call last):

  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_core/intent_services/__init__.py", line 313, in handle_utterance

    for match_func in self.get_pipeline(session=sess):

                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_core/intent_services/__init__.py", line 238, in get_pipeline

    return [matchers[k] for k in pipeline]

           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_core/intent_services/__init__.py", line 238, in <listcomp>

    return [matchers[k] for k in pipeline]

            ~~~~~~~~^^^

KeyError: 'adapt_high'

2024-02-24 18:20:09.464 - skills - ovos_bus_client.client.client:on_default_session_update:161 - DEBUG - synced default_session

```

Update requirements.txt
JarbasAl added a commit that referenced this issue Feb 24, 2024
maybe fixes #417

handle bad pipeline requests based on chat feedback

```
2024-02-24 18:20:09.365 - skills - ovos_core.transformers:transform:60 - DEBUG - ovos-utterance-normalizer: {'client_name': 'ovos_dinkum_listener', 'source': 'VoiceSatelliteV0.3.0:192.168.2.222::53c07e5b-e6a9-4467-bc5b-283842693997', 'destination': ['skills'], 'transcription': 'wie spät ist es', 'session': {'active_skills': [], 'utterance_states': {}, 'session_id': '53c07e5b-e6a9-4467-bc5b-283842693997', 'lang': 'en-us', 'context': {'timeout': 120, 'frame_stack': []}, 'site_id': 'unknown', 'pipeline': ['stop_high', 'converse', 'padatious_high', 'adapt_high', 'fallback_high', 'stop_medium', 'padatious_medium', 'adapt_medium', 'adapt_low', 'common_qa', 'fallback_medium', 'fallback_low'], 'stt': {'plugin_id': 'ovos-stt-plugin-server', 'config': {}}, 'tts': {'plugin_id': 'ovos-tts-plugin-server', 'config': {}}}, 'peer': 'VoiceSatelliteV0.3.0:192.168.2.222::53c07e5b-e6a9-4467-bc5b-283842693997', 'lang': 'de-de'}

2024-02-24 18:20:09.369 - skills - ovos_core.intent_services:handle_utterance:348 - ERROR - 'adapt_high'

Traceback (most recent call last):

  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_core/intent_services/__init__.py", line 313, in handle_utterance

    for match_func in self.get_pipeline(session=sess):

                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_core/intent_services/__init__.py", line 238, in get_pipeline

    return [matchers[k] for k in pipeline]

           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_core/intent_services/__init__.py", line 238, in <listcomp>

    return [matchers[k] for k in pipeline]

            ~~~~~~~~^^^

KeyError: 'adapt_high'

2024-02-24 18:20:09.464 - skills - ovos_bus_client.client.client:on_default_session_update:161 - DEBUG - synced default_session

```

Update requirements.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants