This repository has been archived by the owner on Feb 11, 2024. It is now read-only.
Use correct config option for the log path. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarbasAl
reviewed
Jan 25, 2023
|
I revisited the code. The reference to log_dir is there in the original mycroft cli client but nowhere else. I've reworked the change to add a deprecated warning and still honor log_dir if it's the only variable present. |
|
@JarbasAl anything else needed on this PR ? |
93 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cli client is using the wrong config option to infer the log path.
From ovos-utils, it's using logs.path :
https://github.com/OpenVoiceOS/ovos-utils/blob/c9b1b560dab02d13a77bd9c1f3ad788e65fb9c13/ovos_utils/log.py#L53
This PR fixes this problem.