feat/handle_hex_audiodata #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarbasAl
force-pushed
the
feat/handle_hex_audiodata
branch
from
adef451
to
fb455ce
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #34 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 8
Lines ? 933
Branches ? 0
=====================================
Hits ? 0
Misses ? 933
Partials ? 0 ☔ View full report in Codecov by Sentry. |
JarbasAl
added a commit
to OpenVoiceOS/OVOS-workshop
that referenced
this pull request
Oct 16, 2023
companion to OpenVoiceOS/ovos-audio#34
JarbasAl
added a commit
to OpenVoiceOS/OVOS-workshop
that referenced
this pull request
Oct 16, 2023
companion to OpenVoiceOS/ovos-audio#34
JarbasAl
added a commit
to OpenVoiceOS/OVOS-workshop
that referenced
this pull request
Oct 16, 2023
companion to OpenVoiceOS/ovos-audio#34
JarbasAl
added a commit
to OpenVoiceOS/ovos-messagebus
that referenced
this pull request
Oct 17, 2023
message.data can be huge, this causes the bus to hang a lot of time just printing a log eg, using self.play_audio may print a lot of hex data test with OpenVoiceOS/ovos-audio#34 and easter eggs skill (portal intent)
NeonDaniel
requested changes
Oct 17, 2023
JarbasAl
added a commit
to OpenVoiceOS/ovos-messagebus
that referenced
this pull request
Oct 17, 2023
message.data can be huge, this causes the bus to hang a lot of time just printing a log eg, using self.play_audio may print a lot of hex data test with OpenVoiceOS/ovos-audio#34 and easter eggs skill (portal intent)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow audio binary data to be sent in hex string format
this enables support for ovos-docker and hivemind, companion PR in ovos-workshop also needed for skills